fix(terminal): close tab on process end and speed up long-press select - #2587
Merged
Conversation
Close the terminal tab when the PTY exits or the socket drops, not only when the AXS exit JSON arrives, so users no longer get a dead zombie tab after typing exit. Also lower the default touch selection hold from 600ms to 400ms so long-press select feels more responsive.
Contributor
Greptile SummaryConsolidates terminal shutdown handling and makes touch selection more responsive.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant WS as WebSocket
participant TC as TerminalComponent
participant TM as TerminalManager
participant Tab as Terminal Tab
alt Exit control message
WS->>TC: Text frame (type: exit)
TC->>TM: onProcessExit(data)
else Unexpected disconnect
WS->>TC: close event
TC->>TM: onDisconnect(info)
else Socket error
WS->>TC: error event
TC->>TM: onError(error)
end
TM->>TM: finishTerminalSession()
TM->>TC: dispose()
TM->>Tab: remove()
Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the terminal tab when the PTY exits or the socket drops, not only when the AXS exit JSON arrives, so users no longer get a dead zombie tab after typing exit. Also lower the default touch selection hold from 600ms to 400ms so long-press select feels more responsive.